-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
The --no-sendfile option had a confusing entry in the usage message. Even though sendfile is enabled by default, the --no-sendfile flag showed a true value as the default, which could be interpreted to mean that by default sendfile support is disabled. This change makes the default "None", meaning sendfile is not disabled, which is hopefully slightly more clear. Close #1156
- Loading branch information
There are no files selected for viewing
4 comments
on commit d8b6f0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly the change from store_false to store_const is freaking out argparse. I take guinicorn's options and combine them with my own options. Still digging to see I can find the cause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevgliss let me know if I can help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevgliss can you describe what happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benoitc I have described what I have figured out so far here:
Netflix/lemur#204
For me this throws an error deep down in argparse.py still verifying if its a side effect of flask-script. I'm not positive it's a problem with gunicorn, but is an interesting side effect of this change.
@tilgovi this change breaks the tests since no default is given. Fixed by #1168, let me know what you think about that change.