fix sendfile option validation #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
referenced
this pull request
Dec 28, 2015
The --no-sendfile option had a confusing entry in the usage message. Even though sendfile is enabled by default, the --no-sendfile flag showed a true value as the default, which could be interpreted to mean that by default sendfile support is disabled. This change makes the default "None", meaning sendfile is not disabled, which is hopefully slightly more clear. Close #1156
|
#1169 makes travis-ci return an OK. gaiohttp test is still broken on this branch |
benoitc
force-pushed
the
fix-config-test
branch
from
da1e90f to
6e6c2f6
Compare
|
@tilgovi oups pushed a new version, i missed to commit a part in the config.py on which I moved part of your previous diff. Let me know if it's ok for you. |
|
though maybe we should just keep your change instead of introducing a new property... Anyway let me know :) |
sendfile option don't set any default for now which makes the validation fail (and then tests) since no boolean is given. For now just return when the value is not set.
benoitc
force-pushed
the
fix-config-test
branch
from
6e6c2f6 to
9730978
Compare
|
nvm I'm tired :) pushed the third version just fixing the test. |
|
Okay :-). We can do more another time. On Mon, Dec 28, 2015, 11:41 Benoit Chesneau notifications@github.com
|
|
ok :) merging it. will make the release asap. thanks for the review! |
benoitc
added a commit
that referenced
this pull request
Dec 28, 2015
fix sendfile option validation
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
fix sendfile option validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendfile option don't set any default for now which makes the validation fail
(and then tests) since no boolean is given. For now just return when the value
is not set.