-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to send https request on OTP 22.1 #591
Comments
FWIW I just noticed a similar line with |
Temporary workaround for: benoitc/hackney#591
Is there a workaround to this issue? |
@ruudk, I think only workarounds are downgrade erlang or fork hackney. |
or wait i merge the pr tonight. |
fixed in latest master |
@benoitc are you planning a release for this as well? Not too familiar with your project or release strategy, sorry if it's a silly question. |
@hernanat i will make a release today. Was too late yesterday for it :) |
Hi, can you please increment the Hackney version so that we can pull in changes from Hex for this? Thanks |
Can we get a new version cut? This is a big blocker. I appreciate it! |
While waiting for a new hex release, you can point deps to the github master branch or downgrade to OTP 22.0.7. Both are perfectly viable options ;) |
If anyone is having problems down the chain on Elixir and finds yourself here, here's a quick fix for now: edgurgel/httpoison#393
|
@mdarby just released the version 1.15.2 . Was side-tracked. Hope it helps :) |
Because nobody replied yet: Tested it and verified that it works. Thanks @benoitc ❤️ |
This is to fix the honor_cipher_order error on OTP 22.1 benoitc/hackney#591
This is the issue that is fixed benoitc/hackney#591
thanks boize @lxqnt appreciates mucho calor! |
* There was a hackney OTP 22.1 bug that was breaking IexApiClient requests: benoitc/hackney#591
Due to unannounced breaking change in OTP version 22.1 hackney below the version 1.15.2 stopped working. Older versions are throwing `{:option, :server_only, :honor_cipher_order}` on OTP >= 22.1 and 1.15.2 fixes this issue. Reference: benoitc/hackney#591 edgurgel/httpoison#393
Due to unannounced breaking change in OTP version 22.1 hackney below the version 1.15.2 stopped working. Older versions are throwing `{:option, :server_only, :honor_cipher_order}` on OTP >= 22.1 and 1.15.2 fixes this issue. Reference: benoitc/hackney#591 edgurgel/httpoison#393
Temporary workaround for: benoitc/hackney#591
Temporary workaround for: benoitc/hackney#591
Temporary workaround for: benoitc/hackney#591
Maybe this? benoitc/hackney#591
Update hackney to version 1.15.2 to work around Erlang/OTP 22.1 issue. See benoitc/hackney#591
Hackney returns
{error,{option,server_only,honor_cipher_order}}
with https url, starting from OTP 22.1.Here's a location on ssl library which causes a problem. It seems that
honor_cipher_order
have not been work on client connections so they started blocking it.https://github.com/erlang/otp/blob/bf2dfb7f51fa50d832f4dc4e4e271e7a6df93629/lib/ssl/src/ssl.erl#L1703-L1706
Commenting following line fixes the problem.
https://github.com/benoitc/hackney/blob/master/src/hackney_ssl.erl#L68
The text was updated successfully, but these errors were encountered: