Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(template-syntax): allow nested merge variables #35

Merged
merged 2 commits into from
Apr 13, 2020
Merged

chore(template-syntax): allow nested merge variables #35

merged 2 commits into from
Apr 13, 2020

Conversation

ajpawlicki
Copy link
Contributor

What

  • Updates httpoison because of this error
  • Updates Util.transform_argument/1 to allow nested structs and lists for merge_variables
  • Adds some basic tests for the new template syntax (conditionals, loops, objects)

Why

So this works with the newest api version for the new template syntax

@coveralls
Copy link

coveralls commented Apr 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 952

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 90.625%
Totals Coverage Status
Change from base Build 882: 0.3%
Covered Lines: 29
Relevant Lines: 32
💛 - Coveralls

@ajpawlicki ajpawlicki requested a review from a team April 9, 2020 02:02
ajpawlicki
ajpawlicki commented Apr 9, 2020
View reviewed changes
lib/lob/util.ex Outdated Show resolved Hide resolved
sjl2
sjl2 reviewed Apr 9, 2020
View reviewed changes
lib/lob/util.ex Show resolved Hide resolved
@ajpawlicki ajpawlicki requested review from sjl2 and dmlittle April 10, 2020 23:56
@ajpawlicki ajpawlicki removed the request for review from a team April 13, 2020 17:42
@ajpawlicki ajpawlicki merged commit a28fc52 into master Apr 13, 2020
@ajpawlicki ajpawlicki deleted the ajp-ats branch April 13, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjl2 sjl2 sjl2 approved these changes

@dmlittle dmlittle dmlittle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajpawlicki @coveralls @dmlittle @sjl2