Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown lint fixes + Added missing responsive meta tag #492

Merged
merged 8 commits into from
Jan 25, 2022
Merged

Markdown lint fixes + Added missing responsive meta tag #492

merged 8 commits into from
Jan 25, 2022

Conversation

zeevy
Copy link
Contributor

@zeevy zeevy commented Jan 23, 2022

  • Markdown lint fixes
  • Added missing responsive meta tag for engine/app/views/layouts/good_job/base.html.erb

@zeevy zeevy marked this pull request as draft January 23, 2022 07:51
@zeevy zeevy marked this pull request as ready for review January 23, 2022 09:47
@bensheldon
Copy link
Owner

😍 Thank you!

Would you please split these out into separate PRs? I can merge in the Markdown and the Viewport changes immediately.

I'd like to spend a bit more time with the Dashboard UI changes.

@zeevy zeevy changed the title Dashboard mobile friendly filters + Markdown lint fixes Markdown lint fixes + Added missing responsive meta tag Jan 23, 2022
@zeevy
Copy link
Contributor Author

zeevy commented Jan 23, 2022

😍 Thank you!

Would you please split these out into separate PRs? I can merge in the Markdown and the Viewport changes immediately.

I'd like to spend a bit more time with the Dashboard UI changes.

Sure, I will rise another PR for the dashboard filter ui changes

@bensheldon bensheldon merged commit 6f0a3fa into bensheldon:main Jan 25, 2022
@bensheldon bensheldon added the bug Something isn't working label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants