Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown lint fixes + Added missing responsive meta tag #492

Merged
merged 8 commits into from
Jan 25, 2022
Merged

Markdown lint fixes + Added missing responsive meta tag #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c7c138
Dollar signs used before commands without showing output
zeevy Jan 23, 2022
c2174a5
markdown lint fixes
zeevy Jan 23, 2022
68a5fc0
added missing response meta tag
zeevy Jan 23, 2022
3c572c8
mobile friendly filter + added dropdowns for job_class, queue_name, a…
zeevy Jan 23, 2022
244e3dd
erb lint corrections
zeevy Jan 23, 2022
3744653
restored the list indentation
zeevy Jan 23, 2022
1da9a6e
spec adjustment as per new ui changes
zeevy Jan 23, 2022
ae6f6c0
moving the filter changes to another PR
zeevy Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla
- By default, GoodJob separates job enqueuing from job execution so that jobs can be scaled independently of the web server. Use the GoodJob command-line tool to execute jobs:

```bash
$ bundle exec good_job start
bundle exec good_job start
```

Ideally the command-line tool should be run on a separate machine or container from the web process. For example, on Heroku:
Expand All @@ -133,8 +133,8 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla

- GoodJob can also be configured to execute jobs within the web server process to save on resources. This is useful for low-workloads when economy is paramount.

```
$ GOOD_JOB_EXECUTION_MODE=async rails server
```bash
GOOD_JOB_EXECUTION_MODE=async rails server
```

Additional configuration is likely necessary, see the reference below for configuration.
Expand Down Expand Up @@ -470,7 +470,7 @@ To perform upgrades to the GoodJob database tables:
Optional: If using Rails' multiple databases with the `migrations_paths` configuration option, use the `--database` option:

```bash
$ bin/rails g good_job:update --database animals
bin/rails g good_job:update --database animals
```

1. Run the database migration locally
Expand Down Expand Up @@ -703,7 +703,7 @@ GoodJob can execute jobs "async" in the same process as the web server (e.g. `bi
- Or, with environment variables:

```bash
$ GOOD_JOB_EXECUTION_MODE=async GOOD_JOB_MAX_THREADS=4 GOOD_JOB_POLL_INTERVAL=30 bin/rails server
GOOD_JOB_EXECUTION_MODE=async GOOD_JOB_MAX_THREADS=4 GOOD_JOB_POLL_INTERVAL=30 bin/rails server
```

Depending on your application configuration, you may need to take additional steps:
Expand Down Expand Up @@ -821,7 +821,7 @@ It is also necessary to delete these preserved jobs from the database after a ce
- For example, using the `good_job` command-line utility:

```bash
$ bundle exec good_job cleanup_preserved_jobs --before-seconds-ago=86400
bundle exec good_job cleanup_preserved_jobs --before-seconds-ago=86400
```

### PgBouncer compatibility
Expand Down
2 changes: 2 additions & 0 deletions engine/app/views/layouts/good_job/base.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<html lang="en">
<head>
<title>Good Job Dashboard</title>
<meta charset="utf-8">
<meta content="width=device-width, initial-scale=1, shrink-to-fit=no" name="viewport">
<%= csrf_meta_tags %>
<%= csp_meta_tag %>

Expand Down