Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping otlp deps to 1.15 #3351

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Dec 13, 2022

Courtesy of dependabot.

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

@aarnphm aarnphm requested a review from a team as a code owner December 13, 2022 08:40
@aarnphm aarnphm requested review from sauyon and removed request for a team December 13, 2022 08:40
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #3351 (0351fa7) into main (4895a8c) will increase coverage by 0.29%.
The diff coverage is n/a.

❗ Current head 0351fa7 differs from pull request most recent head e3392d9. Consider uploading reports for the commit e3392d9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   31.62%   31.91%   +0.29%     
==========================================
  Files         138      135       -3     
  Lines       11287    11153     -134     
  Branches     1865     1840      -25     
==========================================
- Hits         3570     3560      -10     
+ Misses       7471     7350     -121     
+ Partials      246      243       -3     
Impacted Files Coverage Δ
src/bentoml/_internal/utils/formparser.py 18.75% <0.00%> (-1.25%) ⬇️
src/bentoml/_internal/container/generate.py 65.57% <0.00%> (-1.10%) ⬇️
src/bentoml/_internal/configuration/containers.py 47.41% <0.00%> (-1.02%) ⬇️
src/bentoml/client.py 0.00% <0.00%> (ø)
src/bentoml/metrics.py 69.23% <0.00%> (ø)
src/bentoml/__init__.py 100.00% <0.00%> (ø)
src/bentoml/_internal/batch/spark.py 0.00% <0.00%> (ø)
src/bentoml/_internal/models/model.py 77.59% <0.00%> (ø)
src/bentoml/_internal/server/server.py 0.00% <0.00%> (ø)
src/bentoml/_internal/io_descriptors/json.py 38.55% <0.00%> (ø)
... and 10 more

@bojiang
Copy link
Member

bojiang commented Dec 22, 2022

@aarnphm We don't have e2e tests for opentelemetry stuff now. Did you test them manually?

sauyon
sauyon previously approved these changes Feb 7, 2023
@sauyon
Copy link
Contributor

sauyon commented Feb 7, 2023

You did test this right?

@aarnphm
Copy link
Contributor Author

aarnphm commented Feb 7, 2023

yep

sauyon
sauyon previously approved these changes Feb 10, 2023
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit 6b00baf into bentoml:main Feb 10, 2023
@aarnphm aarnphm deleted the chore/bumping-otlp-deps branch February 10, 2023 09:50
@bojiang
Copy link
Member

bojiang commented Feb 13, 2023

This change breaks monitoring feature.

bojiang added a commit that referenced this pull request Feb 13, 2023
aarnphm pushed a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants