Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore: bumping otlp deps to 1.15" #3553

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Feb 13, 2023

Reverts #3351
It breaks the monitoring features.

Traceback (most recent call last):                                                                                                                                                                                             
File "/home/agent/BentoML/src/bentoml/_internal/server/http_app.py", line 324, in api_func                                                                                                                                      
output = await api.func(input_data)                                                                                                                                                                                         
File "/home/agent/BentoML/examples/monitoring/task_classification/service.py", line 18, in classify                                                                                                                             
with bentoml.monitor("iris_classifier_prediction") as mon:                                                                                                                                                                  
File "/home/agent/.conda/envs/torch@py3.7/lib/python3.7/contextlib.py", line 112, in __enter__                                                                                                                                  
return next(self.gen)                                                                                                                                                                                                       
File "/home/agent/BentoML/src/bentoml/_internal/monitoring/api.py", line 307, in monitor                                                                                                                                        
from .otlp import OTLPMonitor                                                                                                                                                                                               
File "/home/agent/BentoML/src/bentoml/_internal/monitoring/otlp.py", line 14, in <module>                                                                                                                                       
from opentelemetry.sdk._logs import set_logger_provider                                                                                                                                                                   
ImportError: cannot import name 'set_logger_provider' from 'opentelemetry.sdk._logs' 
(/home/agent/.conda/envs/torch@py3.7/lib/python3.7/site-packages/opentelemetry/sdk/_logs/__init__.py)

@bojiang bojiang requested a review from a team as a code owner February 13, 2023 06:13
@bojiang bojiang requested review from parano, aarnphm and sauyon and removed request for a team and parano February 13, 2023 06:13
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #3553 (3451f4c) into main (cdba3bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3553   +/-   ##
=======================================
  Coverage   31.62%   31.62%           
=======================================
  Files         138      138           
  Lines       11287    11287           
  Branches     1865     1865           
=======================================
  Hits         3570     3570           
  Misses       7471     7471           
  Partials      246      246           

@aarnphm
Copy link
Contributor

aarnphm commented Feb 13, 2023

oh got it. I guess I didn't test the monitoring change 😢

@aarnphm aarnphm changed the title Revert "chore: bumping otlp deps to 1.15" revert: "chore: bumping otlp deps to 1.15" Feb 13, 2023
@aarnphm aarnphm merged commit 9f6e84b into main Feb 13, 2023
@aarnphm aarnphm deleted the revert-3351-chore/bumping-otlp-deps branch February 13, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants