Only use datatables on collection notes list for #3776 #3777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (temporarily?) addresses two issues:
.paginate
call was mistakenly still being called on them.The notes list for a collection -- the focus of #3739 -- is still using DataTables & will now load all notes on a collection. I tested this with around 500 entries and had no performance issues.
Deeds lists, and notes lists without a collection, are back to using
will_paginate
as per usual, no DataTables, so there won't be any performance issues on long lists.