Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use datatables on collection notes list for #3776 #3777

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

sylvieed
Copy link
Collaborator

@sylvieed sylvieed commented Sep 8, 2023

This (temporarily?) addresses two issues:

  1. All deed & note lists were being truncated to 50 items because the .paginate call was mistakenly still being called on them.
  2. If they were not being truncated, there would be major performance issues with loading a large amount of rows without pagination.

The notes list for a collection -- the focus of #3739 -- is still using DataTables & will now load all notes on a collection. I tested this with around 500 entries and had no performance issues.

Deeds lists, and notes lists without a collection, are back to using will_paginate as per usual, no DataTables, so there won't be any performance issues on long lists.

@benwbrum benwbrum linked an issue Sep 8, 2023 that may be closed by this pull request
@benwbrum benwbrum merged commit f27100d into development Sep 8, 2023
1 check passed
@benwbrum benwbrum deleted the 3776-deed-datatables-bug branch May 30, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deed list takes too long to render; causes outages
2 participants