Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter/search comments on a collection #3739

Closed
saracarl opened this issue Aug 10, 2023 · 3 comments · Fixed by #3761
Closed

Filter/search comments on a collection #3739

saracarl opened this issue Aug 10, 2023 · 3 comments · Fixed by #3761
Assignees
@sylvieed
Labels
customer feature

Comments

@saracarl
Copy link
Collaborator

We have a "notes" section for a collection, i.e. https://fromthepage.com/deed/notes/jeremiah-white-graves-diaries

LVA would like a way to search or filter all the notes for the collection (rather than page through them) in order to find things like "mismatch" "duplicate" "missing", etc.

Maybe datatables?
@benwbrum
Copy link
Owner

How is this different from #3738? Just on-screen?

@sylvieed sylvieed self-assigned this Aug 23, 2023
sylvieed added a commit that referenced this issue Aug 24, 2023
@sylvieed
Implemented DataTables to deed list for #3739
3904532
@sylvieed sylvieed mentioned this issue Aug 24, 2023
Merged
@sylvieed sylvieed linked a pull request Aug 24, 2023 that will close this issue
Implemented DataTables to deed list for #3739 #3761
Merged
saracarl added a commit that referenced this issue Aug 29, 2023
@saracarl
Merge pull request #3761 from benwbrum/3739-datatables-notes-list
d3d0dff 
Implemented DataTables to deed list for #3739
sylvieed added a commit that referenced this issue Aug 29, 2023
@sylvieed
Locale health for #3739
a6adc68
@sylvieed sylvieed mentioned this issue Sep 8, 2023
Merged
@benwbrum
Copy link
Owner

I don't think we should close this issue until the pagination mis-match between server-side and Datatables-side problem has been resolved.

@benwbrum benwbrum mentioned this issue Oct 9, 2024
Closed
@benwbrum
Copy link
Owner

benwbrum commented Jan 3, 2025

This was fixed with the #4387

@benwbrum benwbrum closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylvieed sylvieed

Labels
customer feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented DataTables to deed list for #3739 benwbrum/fromthepage
3 participants
@benwbrum @saracarl @sylvieed