Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be yumi_o not ready_o #517

Open
taylor-bsg opened this issue Oct 27, 2021 · 2 comments
Open

Should be yumi_o not ready_o #517

taylor-bsg opened this issue Oct 27, 2021 · 2 comments

Comments

@taylor-bsg
Copy link
Contributor

basejump_stl/bsg_dataflow/bsg_two_buncher.v

Line 68 in cc38e78

assign ready_o = (ready_i[0] & v_i) | ~data_v_r;

@dpetrisko
Copy link
Contributor

Hi @BrendenPage did we fix this one?

@BrendenPage
Copy link
Contributor

Fix should now be in #612 along with the ready_i signal update.

dpetrisko added a commit that referenced this issue Jan 26, 2023
@tommydcjung @dpetrisko @drichmond
Endpoint standard refactor / Credit limit CSR (#479)
833079c 
* refactor

* test_credit_limit_csr_multi

* fix rebase

* add comment assertion

* CR

* set io rtr rev link parameters

* Adding bsg_manycore_endpoint_fc.v (#492)

* Updated DPI interface for endpoint credit refactor (#517)

* Updated DPI interface for endpoint credit refactor
* Change credit handling
* Add DPI methods for tracking response fifo capacity
* Removed my_y_i/my_x_i

* add comment

Co-authored-by: Dan Petrisko <petrisko@cs.washington.edu>
Co-authored-by: Dustin Richmond <dustinar@uw.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dpetrisko @taylor-bsg @BrendenPage