Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron pour envoyer les sondages initiaux par SMS #176

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Cron pour envoyer les sondages initiaux par SMS #176

merged 4 commits into from
Dec 6, 2023

Conversation

Shamzic
Copy link
Contributor

@Shamzic Shamzic commented Nov 10, 2023

Ajoute le cron pour l'envoi du sondage initial par sms et renomage de l'outil d'envoi d'email.

@Shamzic Shamzic self-assigned this Nov 10, 2023
@Shamzic Shamzic mentioned this pull request Nov 10, 2023
Closed
@Shamzic Shamzic changed the title Cron pour envoyer les sondages initiaux par SMS + refacto Cron pour envoyer les sondages initiaux par SMS Nov 14, 2023
@Shamzic Shamzic requested a review from a team November 14, 2023 14:22
@Shamzic Shamzic changed the base branch from main to refactor-email-sms November 15, 2023 10:49
baptou12
baptou12 reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@baptou12 baptou12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Là on utilise node, ce qui est bien en prod (vs ts-node) mais ça me fait dire que la commande dans le package.json n'est p.e. pas utile, t'en pense quoi ?

cf betagouv/aides-jeunes@f2ceeb5

@Shamzic
Copy link
Contributor Author

Shamzic commented Nov 21, 2023

Là on utilise node, ce qui est bien en prod (vs ts-node) mais ça me fait dire que la commande dans le package.json n'est p.e. pas utile, t'en pense quoi ?

cf betagouv/aides-jeunes@f2ceeb5

Elle n'est pas utile en prod mais pour le dev, je l'ai utilisée un paquet de fois!

@Shamzic Shamzic mentioned this pull request Nov 21, 2023
Merged
@Shamzic Shamzic changed the base branch from refactor-email-sms to main December 5, 2023 13:51
baptou12
baptou12 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@baptou12 baptou12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, en revanche a mergé après 17h si on veut controller l'envoi pour le moment ?

@Shamzic Shamzic merged commit 6564ea5 into main Dec 6, 2023
4 checks passed
@guillett guillett deleted the feat-sms-cron branch February 7, 2024 09:48
@guillett guillett added this to the Passé milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baptou12 baptou12 baptou12 approved these changes

Assignees

@Shamzic Shamzic

Labels
None yet
Projects
None yet
Milestone
Passé
Development

Successfully merging this pull request may close these issues.
3 participants
@Shamzic @baptou12 @guillett