Ajoute l'envoi des sondages par SMS #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2023
Shamzic
force-pushed
the
feature-envoi-survey-sms-v2
branch
from
124a509 to
fa1eb83
Compare
Shamzic
force-pushed
the
refactor-email-sms
branch
from
08007fc to
e53f734
Compare
Shamzic
force-pushed
the
feature-envoi-survey-sms-v2
branch
2 times, most recently
from
d049756 to
f309000
Compare
baptou12
suggested changes
Nov 29, 2023
baptou12
force-pushed
the
feature-envoi-survey-sms-v2
branch
from
a541873 to
fe06278
Compare
|
Dernier ajout de test unitaire WIP |
Shamzic
force-pushed
the
feature-envoi-survey-sms-v2
branch
from
ddca8b9 to
443d077
Compare
baptou12
reviewed
Nov 30, 2023
Shamzic
force-pushed
the
feature-envoi-survey-sms-v2
branch
4 times, most recently
from
ff1fe01 to
758e7b0
Compare
… (sms de sondage)
…lace du findSurvey
Shamzic
force-pushed
the
feature-envoi-survey-sms-v2
branch
2 times, most recently
from
238a7ba to
dd14c9a
Compare
Shamzic
force-pushed
the
feature-envoi-survey-sms-v2
branch
from
c2b7a68 to
f83f3d2
Compare
baptou12
suggested changes
Dec 4, 2023
Oui, c'est fonctionnel de mon côté |
baptou12
reviewed
Dec 4, 2023
baptou12
suggested changes
Dec 4, 2023
baptou12
reviewed
Dec 4, 2023
…+ déplace le sort
baptou12
approved these changes
Dec 4, 2023
Merci, partisan du merge demain matin avec des envois ayants un limit réduit si il y a des craintes de crash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Envoyer des SMS contenant le lien du sondage (sous conditions spécifiées ci-dessous) après la réalisation d'une simulation (comportement similaire à l'envoi par e-mail).
L'accès au sondage via le lien du SMS se fera par une route de redirection raccourcie (api/r/).
Le sondage est envoyé par SMS selon les conditions suivantes :
Historique
Réécriture au propre d'une première itération disponible ici.
Tâche sur l'ops
Ajouter un cron hebdomadaire d'envoi de sondage par SMS similaire à celui par e-mail.
Pull Request associée : Cron pour l'envoi des sondages par SMS
Refactoring lié et précédant ces ajouts
Tester la PR
Envoyer des liens de sondage pour tous les suivis (maximum 2 envois) respectant les critères d'envoi : utiliser la commande
npm run tools:send-initial-survey-smsen ayant au préalable indiqué les identifiants Netsize en variable d'environnement.Exécuter les tests unitaires du fichier
messaging-sms.spec.tsciblant la méthode de calcul des critères d'envoi du sondage par SMS. => peut encore être approfondi.