Skip to content

Commit

Permalink
add some info from ReflectPathError to the error messages (#5626)
Browse files Browse the repository at this point in the history
# Objective

- The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name`
- it has info for better messages available

## Solution

- make the display impl more descriptive by including values from the type
  • Loading branch information
jakobhellermann committed Aug 9, 2022
1 parent fe97b38 commit 166279e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions crates/bevy_reflect/src/path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@ use thiserror::Error;
/// An error returned from a failed path string query.
#[derive(Debug, PartialEq, Eq, Error)]
pub enum ReflectPathError<'a> {
#[error("expected an identifier at the given index")]
#[error("expected an identifier at index {index}")]
ExpectedIdent { index: usize },
#[error("the current struct doesn't have a field with the given name")]
#[error("the current struct doesn't have a field with the name `{field}`")]
InvalidField { index: usize, field: &'a str },
#[error("the current tuple struct doesn't have a field with the given index")]
#[error("the current tuple struct doesn't have a field with the index {tuple_struct_index}")]
InvalidTupleStructIndex {
index: usize,
tuple_struct_index: usize,
},
#[error("the current list doesn't have a value at the given index")]
#[error("the current list doesn't have a value at the index {list_index}")]
InvalidListIndex { index: usize, list_index: usize },
#[error("encountered an unexpected token")]
#[error("encountered an unexpected token `{token}`")]
UnexpectedToken { index: usize, token: &'a str },
#[error("expected a token, but it wasn't there.")]
#[error("expected token `{token}`, but it wasn't there.")]
ExpectedToken { index: usize, token: &'a str },
#[error("expected a struct, but found a different reflect value")]
ExpectedStruct { index: usize },
Expand Down

0 comments on commit 166279e

Please sign in to comment.