Skip to content

Commit

Permalink
Disabling default features support in bevy_ecs, bevy_reflect and bevy (
Browse files Browse the repository at this point in the history
…#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by #5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
  • Loading branch information
mockersf committed Oct 24, 2022
1 parent e4af823 commit 64a8485
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/bors.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ status = [
"check-compiles",
"build-and-install-on-iOS",
"run-examples-on-windows-dx12",
"build-without-default-features (bevy)",
"build-without-default-features (bevy_ecs)",
"build-without-default-features (bevy_reflect)",
]

use_squash_merge = true
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/validation-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,22 @@ jobs:
with:
name: screenshots
path: .github/start-wasm-example/screenshot-*.png

build-without-default-features:
strategy:
matrix:
crate: [bevy_ecs, bevy_reflect, bevy]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
- name: Install alsa and udev
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
- name: Build
run: cargo build -p ${{ matrix.crate }} --no-default-features
env:
CARGO_INCREMENTAL: 0
RUSTFLAGS: "-C debuginfo=0 -D warnings"
1 change: 0 additions & 1 deletion crates/bevy_ecs/src/change_detection.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Types that detect when their internal data mutate.

use crate::{component::ComponentTicks, ptr::PtrMut, system::Resource};
#[cfg(feature = "bevy_reflect")]
use std::ops::{Deref, DerefMut};

/// The (arbitrarily chosen) minimum number of world tick increments between `check_tick` scans.
Expand Down

0 comments on commit 64a8485

Please sign in to comment.