rename Visibility::Shown variant again, this time to Inherited

crates/bevy_gltf/src/loader.rs

@@ -465,7 +465,7 @@ async fn load_gltf<'a, 'b>(
         let mut entity_to_skin_index_map = HashMap::new();
 
         world
-            .spawn(SpatialBundle::SHOWN_IDENTITY)
+            .spawn(SpatialBundle::INHERITED_IDENTITY)
             .with_children(|parent| {
                 for node in scene.nodes() {
                     let result = load_node(

crates/bevy_render/src/spatial_bundle.rs

@@ -33,13 +33,13 @@ impl SpatialBundle {
     pub const fn from_transform(transform: Transform) -> Self {
         SpatialBundle {
             transform,
-            ..Self::SHOWN_IDENTITY
+            ..Self::INHERITED_IDENTITY
         }
     }
 
     /// A visible [`SpatialBundle`], with no translation, rotation, and a scale of 1 on all axes.
-    pub const SHOWN_IDENTITY: Self = SpatialBundle {
-        visibility: Visibility::Shown,
+    pub const INHERITED_IDENTITY: Self = SpatialBundle {
+        visibility: Visibility::Inherited,
         computed: ComputedVisibility::HIDDEN,
         transform: Transform::IDENTITY,
         global_transform: GlobalTransform::IDENTITY,
@@ -48,7 +48,7 @@ impl SpatialBundle {
     /// An invisible [`SpatialBundle`], with no translation, rotation, and a scale of 1 on all axes.
     pub const HIDDEN_IDENTITY: Self = SpatialBundle {
         visibility: Visibility::Hidden,
-        ..Self::SHOWN_IDENTITY
+        ..Self::INHERITED_IDENTITY
     };
 }
 

crates/bevy_render/src/view/visibility/mod.rs

@@ -30,13 +30,13 @@ use crate::{
 #[derive(Component, Clone, Copy, Reflect, Debug, PartialEq, Eq)]
 #[reflect(Component, Default)]
 pub enum Visibility {
-    Shown,
+    Inherited,
     Hidden,
 }
 
 impl Default for Visibility {
     fn default() -> Self {
-        Self::Shown
+        Self::Inherited
     }
 }
 
@@ -46,29 +46,33 @@ impl Not for Visibility {
     #[inline]
     fn not(self) -> Visibility {
         match self {
-            Visibility::Shown => Visibility::Hidden,
-            Visibility::Hidden => Visibility::Shown,
+            Visibility::Inherited => Visibility::Hidden,
+            Visibility::Hidden => Visibility::Inherited,
         }
     }
 }
 
 impl Visibility {
-    /// Whether this entity is visible.
+    /// Whether this entity is Inherited.
     #[inline]
-    pub const fn is_visible(&self) -> bool {
-        matches!(self, Self::Shown)
+    pub const fn is_inherited(&self) -> bool {
+        matches!(self, Self::Inherited)
     }
 
-    /// Toggle the visibility.
+    /// Toggle the visibility state between Inherited and Hidden.
     #[inline]
     pub fn toggle(&mut self) {
         *self = !*self;
     }
 
-    /// Set the visibility using a boolean expression.
+    /// Set the visibility to either Inherited or Hidden using a boolean expression.
     #[inline]
-    pub fn set(&mut self, shown: bool) {
-        *self = if shown { Self::Shown } else { Self::Hidden }
+    pub fn set(&mut self, inherited: bool) {
+        *self = if inherited {
+            Self::Inherited
+        } else {
+            Self::Hidden
+        }
     }
 }
 
@@ -289,7 +293,7 @@ fn visibility_propagate_system(
     children_query: Query<&Children, (With<Parent>, With<Visibility>, With<ComputedVisibility>)>,
 ) {
     for (children, visibility, mut computed_visibility, entity) in root_query.iter_mut() {
-        computed_visibility.is_visible_in_hierarchy = visibility.is_visible();
+        computed_visibility.is_visible_in_hierarchy = visibility.is_inherited();
         // reset "view" visibility here ... if this entity should be drawn a future system should set this to true
         computed_visibility.is_visible_in_view = false;
         if let Some(children) = children {
@@ -322,7 +326,7 @@ fn propagate_recursive(
             child_parent.get(), expected_parent,
             "Malformed hierarchy. This probably means that your hierarchy has been improperly maintained, or contains a cycle"
         );
-        computed_visibility.is_visible_in_hierarchy = visibility.is_visible() && parent_visible;
+        computed_visibility.is_visible_in_hierarchy = visibility.is_inherited() && parent_visible;
         // reset "view" visibility here ... if this entity should be drawn a future system should set this to true
         computed_visibility.is_visible_in_view = false;
         computed_visibility.is_visible_in_hierarchy

examples/2d/mesh2d_manual.rs

@@ -103,7 +103,7 @@ fn star(
         // The `Handle<Mesh>` needs to be wrapped in a `Mesh2dHandle` to use 2d rendering instead of 3d
         Mesh2dHandle(meshes.add(star)),
         // This bundle's components are needed for something to be rendered
-        SpatialBundle::SHOWN_IDENTITY,
+        SpatialBundle::INHERITED_IDENTITY,
     ));
 
     // Spawn the camera

examples/animation/animated_transform.rs

@@ -129,7 +129,7 @@ fn setup(
         .with_children(|p| {
             // This entity is just used for animation, but doesn't display anything
             p.spawn((
-                SpatialBundle::SHOWN_IDENTITY,
+                SpatialBundle::INHERITED_IDENTITY,
                 // Add the Name component
                 orbit_controller,
             ))

examples/shader/shader_instancing.rs

@@ -32,7 +32,7 @@ fn main() {
 fn setup(mut commands: Commands, mut meshes: ResMut<Assets<Mesh>>) {
     commands.spawn((
         meshes.add(Mesh::from(shape::Cube { size: 0.5 })),
-        SpatialBundle::SHOWN_IDENTITY,
+        SpatialBundle::INHERITED_IDENTITY,
         InstanceMaterialData(
             (1..=10)
                 .flat_map(|x| (1..=10).map(move |y| (x as f32 / 10.0, y as f32 / 10.0)))

examples/stress_tests/many_foxes.rs

@@ -111,7 +111,7 @@ fn setup(
         let (base_rotation, ring_direction) = ring_directions[ring_index % 2];
         let ring_parent = commands
             .spawn((
-                SpatialBundle::SHOWN_IDENTITY,
+                SpatialBundle::INHERITED_IDENTITY,
                 ring_direction,
                 Ring { radius },
             ))