Skip to content

Commit

Permalink
change the default width and height of Size to Val::Auto (#7475)
Browse files Browse the repository at this point in the history
# Objective

In CSS Flexbox width and height are auto by default, whereas in Bevy their default is `Size::Undefined`.
This means that, unlike in CSS, if you elide a height or width value for a node it will be given zero length (unless it has an explicitly sized child node). This has misled users into falsely assuming that they have to explicitly set a value for both height and width all the time.

relevant issue: #7120

## Solution

Change the `Size` `width` and `height` default values to `Val::Auto`

## Changelog

* Changed the `Size` `width` and `height` default values to `Val::Auto`

## Migration Guide

The default values for `Size` `width` and `height` have been changed from `Val::Undefined` to `Val::Auto`.
It's unlikely to cause any issues with existing code.
  • Loading branch information
ickshonpe committed Feb 3, 2023
1 parent 9b189a9 commit c480352
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/bevy_ui/src/geometry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ pub struct Size {
}

impl Size {
pub const DEFAULT: Self = Self::all(Val::DEFAULT);
pub const DEFAULT: Self = Self::all(Val::Auto);

/// Creates a new [`Size`] from a width and a height.
///
Expand Down

0 comments on commit c480352

Please sign in to comment.