Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetPlugin always creates empty assets directory #11208

Closed
nvdaz opened this issue Jan 3, 2024 · 0 comments · Fixed by #11218
Closed

AssetPlugin always creates empty assets directory #11208

nvdaz opened this issue Jan 3, 2024 · 0 comments · Fixed by #11218
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior

Comments

@nvdaz
Copy link
Contributor

nvdaz commented Jan 3, 2024 •
edited
Loading

Bevy version

0.12.1 and b6da40c

What you did

App::new().add_plugins(AssetPlugin::default());

What went wrong

Merely adding AssetPlugin to an app creates an assets directory. Projects that don't load assets from the file system are left with an empty folder. This folder was not auto created in 0.11.

Additional information

Looks like this behavior was added in #8624.
The folder is created here.
@nvdaz nvdaz added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jan 3, 2024
@nvdaz nvdaz mentioned this issue Jan 4, 2024
Merged
@nicopap nicopap added A-Assets Load files from disk to use for things like images, models, and sounds and removed S-Needs-Triage This issue needs to be labelled labels Jan 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
@nvdaz @alice-i-cecile @nicopap
Don't auto create assets folder (#11218)
2847cc6 
# Objective

- Don't automatically create an assets folder
- resolves #11208

## Solution

- Removes directory creation from file reader.
- Clearer panic when using file watcher and asset folder doesn't exist

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't auto create assets folder nvdaz/bevy
2 participants
@nicopap @nvdaz