Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window_settings example never becomes visible #11273

Closed
IceSentry opened this issue Jan 9, 2024 · 2 comments · Fixed by #11325
Closed

window_settings example never becomes visible #11273

IceSentry opened this issue Jan 9, 2024 · 2 comments · Fixed by #11325
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior O-Windows Specific to the Windows desktop operating system P-Regression Functionality that used to work but no longer does. Add a test for this!
Milestone
0.13

Comments

@IceSentry
Copy link
Contributor

Bevy version

bug started appearing after #11227

Relevant system information

INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce RTX 4080", vendor: 4318, device: 9988, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "546.33", backend: Vulkan }
INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 10 Pro", kernel: "19045", cpu: "", core_count: "8", memory: "63.9 GiB" }

What you did

cargo run --example window_settings

What went wrong

The window never becomes visible

Additional information

For some reason, Update systems never get called when the window is invisible.
@IceSentry IceSentry added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled A-Windowing Platform-agnostic interface layer to run your app in and removed S-Needs-Triage This issue needs to be labelled labels Jan 9, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Jan 9, 2024
@IceSentry IceSentry added the P-Regression Functionality that used to work but no longer does. Add a test for this! label Jan 9, 2024
@tim-blackbird
Copy link
Contributor

It's working for me on linux. Probably a platform specific issue

2024-01-09T19:30:19.951951Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon RX 7900 XTX (RADV NAVI31)", vendor: 4098, device: 29772, device_type: DiscreteGpu, driver: "radv", driver_info: "Mesa 23.3.2-arch1.2", backend: Vulkan }
2024-01-09T19:30:20.446509Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Linux rolling EndeavourOS", kernel: "6.6.10-arch1-1", cpu: "", core_count: "8", memory: "31.2 GiB" }

@mockersf
Copy link
Member

Works on macOS too, and failure reproduced in CI on Windows

@mockersf mockersf added the O-Windows Specific to the Windows desktop operating system label Jan 10, 2024
This was referenced Jan 11, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 15, 2024
@mockersf
Fix Reactive and ReactiveLowPower update modes (#11325)
3d628a8 
# Objective

- Partial fix for #11235 
- Fixes #11274 
- Fixes #11320 
- Fixes #11273

## Solution

- check update mode to trigger redraw request, instead of once a redraw
request has been triggered
- don't ignore device event in case of `Reactive` update mode
- make sure that at least 5 updates are triggered on application start
to ensure everything is correctly initialized
- trigger manual updates instead of relying on redraw requests when
there are no window or they are not visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior O-Windows Specific to the Windows desktop operating system P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Fix Reactive and ReactiveLowPower update modes mockersf/bevy
4 participants
@alice-i-cecile @IceSentry @mockersf @tim-blackbird