Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two_passes example breaking on Windows #11755

Closed
afonsolage opened this issue Feb 7, 2024 · 3 comments · Fixed by #11758
Closed

two_passes example breaking on Windows #11755

afonsolage opened this issue Feb 7, 2024 · 3 comments · Fixed by #11758
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Milestone

Comments

@afonsolage
Copy link
Contributor

Bevy version

Main (f514d5c)

Relevant system information

AdapterInfo { name: "AMD Radeon RX 6750 XT", vendor: 4098, device: 29663, device_type: DiscreteGpu, driver: "AMD proprietary driver", driver_info: "24.1.1 (AMD proprietary shader compiler)", backend: Vulkan }
SystemInfo { os: "Windows 11 Pro", kernel: "22631", cpu: "", core_count: "6", memory: "31.9 GiB" }

What you did

cargo run --example two_passes

What went wrong

Sometimes it crashes (in 5 runs, crashes 2 times). The problem is only on startup, after that, seems to be working fine.

thread '<unnamed>' panicked at crates\bevy_core_pipeline\src\msaa_writeback.rs:83:18:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in exclusive system `bevy_render::renderer::render_system`!
thread 'Compute Task Pool (5)' panicked at crates\bevy_render\src\pipelined_rendering.rs:145:45:
called `Result::unwrap()` on an `Err` value: RecvError
error: process didn't exit successfully: `target\debug\examples\two_passes.exe` (exit code: 101)

backtrace.log

Additional information

Seems to be related to #10812, since it works fine on commit 7705c1d but breaks on 9f7e61b

@afonsolage afonsolage added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 7, 2024
@BorisBoutillier
Copy link
Contributor

This is not specific to windows, I have reproduced the issue on Linux.

@mockersf mockersf added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Feb 7, 2024
@mockersf mockersf added this to the 0.13 milestone Feb 7, 2024
@mockersf
Copy link
Member

mockersf commented Feb 7, 2024

I can't reproduce on macOS

This should be investigated for the 0.13 so we have an idea of the underlying issue

@BorisBoutillier
Copy link
Contributor

Msaa_writeback is the only file that miss the checking of the result when getting the pipeline.
Doing a PR to fix that

github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2024
# Objective

- This aims to fix #11755
- After #10812 some pipeline compilation can take more time than before
and all call to `get_render_pipeline` should check the result.

## Solution

- Check `get_render_pipeline` call result for msaa_writeback
- I checked that no other call to `get_render_pipeline` in bevy code
base is missng the checking on the result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants