Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async pipeline creation to be disabled #11846

Closed
rparrett opened this issue Feb 13, 2024 · 0 comments · Fixed by #11847
Closed

Allow async pipeline creation to be disabled #11846

rparrett opened this issue Feb 13, 2024 · 0 comments · Fixed by #11847
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible

Comments

@rparrett
Copy link
Contributor

rparrett commented Feb 13, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

Followup to #10812

pcwalton left a comment
Is there any way for an app to request that pipelines be synchronously built: i.e. to turn this behavior off? I worry that just having objects silently not appear for a few frames is not the behavior that every app wants.

What solution would you like?

JMS55 commented 2 weeks ago
I'd like to leave that to a followup. We can put it in the RenderPlugin settings, but it's a bit of a pain.

What alternative(s) have you considered?

A proper way of doing pipeline preloading would be more useful, but that seems far off.

Additional context

It seems like this would be especially desirable for apps that are doing automatic screenshotting -- without this they would need to either wait some arbitrary amount of time before screenshotting, or track pipeline status.
@rparrett rparrett added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen S-Needs-Triage This issue needs to be labelled labels Feb 13, 2024
@mockersf mockersf removed the S-Needs-Triage This issue needs to be labelled label Feb 13, 2024
@rparrett rparrett mentioned this issue Feb 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 16, 2024
@rparrett @JMS55 @mockersf
Add configuration for async pipeline creation on RenderPlugin (#11847)
ebaa347 
# Objective

Fixes #11846

## Solution

Add a `synchronous_pipeline_compilation ` field to `RenderPlugin`,
defaulting to `false`.

Most of the diff is whitespace.

## Changelog

Added `synchronous_pipeline_compilation ` to `RenderPlugin` for
disabling async pipeline creation.

## Migration Guide

TODO: consider combining this with the guide for #11846

`RenderPlugin` has a new `synchronous_pipeline_compilation ` property.
The default value is `false`. Set this to `true` if you want to retain
the previous synchronous behavior.

---------

Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
Co-authored-by: François <mockersf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add configuration for async pipeline creation on RenderPlugin rparrett/bevy
2 participants
@rparrett @mockersf