When VIEWPORT is set to CAMERA and switched to SizedFullscreen, PANIC may occur.

[hyoi]

Bevy version

v0.13.0, 0.13.1

Relevant system information

2024-02-20T12:45:02.631105Z  INFO bevy_render::renderer: AdapterInfo { name: "Intel(R) Iris(R) Xe Graphics", vendor: 32902, device: 18086, device_type: IntegratedGpu, driver: "Intel Corporation", driver_info: "Intel driver", backend: Vulkan }
2024-02-20T12:45:04.399604Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 11 Home", kernel: "22621", cpu: "12th Gen Intel(R) Core(TM) i7-1260P", core_count: "12", memory: "31.7 GiB" }
2024-02-20T12:45:09.668606Z ERROR log: Handling wgpu errors as fatal by default    
thread '<unnamed>' panicked at C:\Users\hyoi\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wgpu-0.19.1\src\backend\wgpu_core.rs:3009:5:
wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 181, Vulkan)>`     
    In a set_viewport command
    Viewport has invalid rect Rect { x: 0.0, y: 0.0, w: 1376.0, h: 768.0 }; origin and/or size is less than or equal to 0, and/or is not contained in the render target (1366, 768, 1) 


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in exclusive system `bevy_render::renderer::render_system`!
thread 'Compute Task Pool (1)' panicked at C:\Users\hyoi\.cargo\registry\src\index.crates.io-6f17d22bba15001f\bevy_render-0.13.0\src\pipelined_rendering.rs:49:67:
called `Result::unwrap()` on an `Err` value: RecvError       
error: process didn't exit successfully: `target\release\work.exe` (exit code: 101)

What you did

On my PC, I can reproduce PANIC with the following program.
This program first displays an empty window, and then the [SPACE] key toggles between Windowed and SizedFullscreen display.
PANIC occurs when WINDOW_WIDTH is 1376.0, and there is no problem when WINDOW_WIDTH is 1366.0.

use bevy::
{   prelude::*,
    render::camera::Viewport,
    window::WindowMode,
};

// const WINDOW_WIDTH : f32 = 1366.0; //No problem
const WINDOW_WIDTH : f32 = 1376.0; //Panic: Viewport has invalid rect
const WINDOW_HEIGHT: f32 = 768.0;

fn main()
{   //Specify Window Size.
    let window = Window { resolution: ( WINDOW_WIDTH, WINDOW_HEIGHT ).into(), ..default() };
    let primary_window = Some ( window );

    App::new()
        .add_plugins( DefaultPlugins.set( WindowPlugin { primary_window, ..default() } ) )
        .add_systems( Startup, startup )
        .add_systems( Update, toggle_window_mode )
        .run();
}

fn startup( mut cmds: Commands )
{   //Match viewport to Window size.
    let physical_position = UVec2::new( 0, 0 );
    let physical_size = Vec2::new( WINDOW_WIDTH, WINDOW_HEIGHT ).as_uvec2();
    let viewport = Some ( Viewport { physical_position, physical_size, ..default() } );

    cmds.spawn( Camera2dBundle::default() ).insert( Camera { viewport, ..default() } );
}

fn toggle_window_mode
(   mut qry_window: Query<&mut Window>,
    inkey: Res<ButtonInput<KeyCode>>,
)
{   let Ok( mut window ) = qry_window.get_single_mut() else { return };

    //Press [SPACE] key to toggle between window and full screen.
    if inkey.just_pressed( KeyCode::Space )
    {   window.mode = match window.mode
        {   WindowMode::Windowed => WindowMode::SizedFullscreen,
            _                    => WindowMode::Windowed,
        };
    }
}

What went wrong

• VIEWPORT validation has been added to WGPU V0.18.0. #4058
• I thought that if the resolution after SizedFullscreen setting is lower than the original window resolution, the VIEWPORT would result in a validation error and PANIC.

[hyoi]

Checked for panic in v0.13.1.

[hyoi]

I changed [dependencies] in Cargo.toml as follows and compiled it, and now the trouble does not occur on my PC. Thank you very much, LuisFigueiredo73 .

[dependencies]
bevy = { git = "https://github.com/LuisFigueiredo73/bevy", branch = "Viewport_panic" }
#bevy = "0.13.1"