Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check example showcase patches in CI #12441

Closed
rparrett opened this issue Mar 12, 2024 · 1 comment · Fixed by #12457
Closed

Check example showcase patches in CI #12441

rparrett opened this issue Mar 12, 2024 · 1 comment · Fixed by #12457
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible

Comments

@rparrett
Copy link
Contributor

rparrett commented Mar 12, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

When PRs are merged, the "example-showcase patches" can go stale and break tooling that relies on example-showcase.

For example, the automated screenshot diffing happening at https://thebevyflock.github.io/bevy-example-runner/. I also hit this recently in my own local screenshot diffing infrastructure.

Motivated by:

#12440
#11596
#11058

What solution would you like?

Add CI that checks to make sure the patches apply.

What alternative(s) have you considered?

Add CI-only rust code / APIs for doing the overrides that these patches are doing.
@rparrett rparrett added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Mar 12, 2024
@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration and removed S-Needs-Triage This issue needs to be labelled labels Mar 12, 2024
@BD103
Copy link
Member

BD103 commented Mar 13, 2024

I'm thinking something like git apply path/to/foo.patch, and then checking if it exits with a non-zero code. This sounds quite easy to do in Github Actions.

Should this be included in the ci tool, or just Github Actions?

@mockersf mockersf mentioned this issue Mar 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 17, 2024
@mockersf
check that patches are not broken (#12457)
39385be 
# Objective

- Fixes #12441 
- check that patches are still working

## Solution

- Apply all patches then build Bevy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check that patches are not broken mockersf/bevy
3 participants
@rparrett @alice-i-cecile @BD103