Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FloatOrd into bevy_math #12712

Closed
alice-i-cecile opened this issue Mar 25, 2024 · 0 comments · Fixed by #12732
Closed

Move FloatOrd into bevy_math #12712

alice-i-cecile opened this issue Mar 25, 2024 · 0 comments · Fixed by #12732
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

Utility crates are messy and hard to maintain. See #11478 for more rationale. FloatOrd (see e.g. #12711) has a natural home in bevy_math, with our other mathematical primitives.

What solution would you like?

Move FloatOrd there.

What alternative(s) have you considered?

We could also split this out into its own micro-crate.
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations A-Utils Utility functions and types labels Mar 25, 2024
@OneFourth OneFourth mentioned this issue Mar 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@OneFourth
Move FloatOrd into bevy_math (#12732)
4508077 
# Objective

- Fixes #12712

## Solution

- Move the `float_ord.rs` file to `bevy_math`
- Change any `bevy_utils::FloatOrd` statements to `bevy_math::FloatOrd`

---

## Changelog

- Moved `FloatOrd` from `bevy_utils` to `bevy_math`

## Migration Guide

- References to `bevy_utils::FloatOrd` should be changed to
`bevy_math::FloatOrd`
@mnmaita mnmaita mentioned this issue May 23, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move FloatOrd into bevy_math OneFourth/bevy
1 participant
@alice-i-cecile