Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fog toggling shader flag is suboptimal #13802

Open
alice-i-cecile opened this issue Jun 10, 2024 · 2 comments
Open

Fog toggling shader flag is suboptimal #13802

alice-i-cecile opened this issue Jun 10, 2024 · 2 comments
Labels
A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Shaders This code uses GPU shader languages D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jun 10, 2024 •
edited
Loading

This wasn't done the right way, I don't think. What I suggested was to make the FOG_ENABLED shader def contingent on whether the view has fog, not whether the material had a flag that disables it.

Originally posted by @pcwalton in #13783 (comment)
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Shaders This code uses GPU shader languages C-Performance A change motivated by improving speed, memory usage or compile times D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jun 10, 2024
@pcwalton
Copy link
Contributor

It does work correctly, so it's not technically a bug, it's just not designed optimally I don't think.

@alice-i-cecile alice-i-cecile removed the C-Bug An unexpected or incorrect behavior label Jun 10, 2024
@alice-i-cecile alice-i-cecile changed the title Fog toggling shader flag doesn't work correctly Fog toggling shader flag is suboptimal Jun 10, 2024
@alice-i-cecile
Copy link
Member Author

This PR also caused a regression with fog in general, so for now we should just revert it.

@alice-i-cecile alice-i-cecile mentioned this issue Jun 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 10, 2024
@alice-i-cecile
Revert "Make FOG_ENABLED a shader_def instead of material flag (#13783)…
d659a1f 
…" (#13803)

This reverts commit 3ced49f.

Relevant to #13802. This wasn't
done quite right and partially broke fog.

Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
mockersf pushed a commit that referenced this issue Jun 11, 2024
@alice-i-cecile @mockersf
Revert "Make FOG_ENABLED a shader_def instead of material flag (#13783)…
92176ce 
…" (#13803)

This reverts commit 3ced49f.

Relevant to #13802. This wasn't
done quite right and partially broke fog.

Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Shaders This code uses GPU shader languages D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcwalton @alice-i-cecile