Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asymmetrical 9-slicing still doesn't work if the center tile begins more than halfway from an edge #14147

Closed
JJJimbo1 opened this issue Jul 5, 2024 · 0 comments · Fixed by #14148
Closed

asymmetrical 9-slicing still doesn't work if the center tile begins more than halfway from an edge #14147

JJJimbo1 opened this issue Jul 5, 2024 · 0 comments · Fixed by #14148
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@JJJimbo1
Copy link
Contributor

JJJimbo1 commented Jul 5, 2024

Bevy version

Bevy 0.14.0

What you did

Used an asymmetrical 9-slice texture.

What went wrong

Texture is stretched and not sliced.

Additional information

asymmetrical_texture_slice_before

#13921 partially fixed this issue. I have created a pull request with the complete solution.
@JJJimbo1 JJJimbo1 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 5, 2024
@JJJimbo1 JJJimbo1 mentioned this issue Jul 5, 2024
Merged
@JJJimbo1 JJJimbo1 changed the title asymmetrical 9-slicing is still broken asymmetrical 9-slicing still doesn't work if the center tile begins more than halfway from an edge Jul 7, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Investigation This issue requires detective work to figure out what's going wrong S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled S-Needs-Investigation This issue requires detective work to figure out what's going wrong labels Jul 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2024
@JJJimbo1 @alice-i-cecile
fix asymmetrical 9-slicing (#14148)
56c9d44 
# Objective

Fixes #14147.

## Solution

Modify the slicing checks and algorithm to fully allow asymmetrical
textures to work.
Some opinionated code cleanup.

## Testing

Tested using the ui_texture_slice example and a custom asymmetrical
texture.

Before:

![asymmetrical_texture_slice_before](https://github.com/bevyengine/bevy/assets/88861660/00dafce1-904a-41ac-b5d9-faaf087b0681)

After:

![asymmetrical_texture_slice_after](https://github.com/bevyengine/bevy/assets/88861660/f3d742f3-6157-4d35-b383-aee4b8f6e7d0)

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
mockersf pushed a commit that referenced this issue Aug 2, 2024
@JJJimbo1 @alice-i-cecile @mockersf
fix asymmetrical 9-slicing (#14148)
d888640 
# Objective

Fixes #14147.

## Solution

Modify the slicing checks and algorithm to fully allow asymmetrical
textures to work.
Some opinionated code cleanup.

## Testing

Tested using the ui_texture_slice example and a custom asymmetrical
texture.

Before:

![asymmetrical_texture_slice_before](https://github.com/bevyengine/bevy/assets/88861660/00dafce1-904a-41ac-b5d9-faaf087b0681)

After:

![asymmetrical_texture_slice_after](https://github.com/bevyengine/bevy/assets/88861660/f3d742f3-6157-4d35-b383-aee4b8f6e7d0)

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix asymmetrical 9-slicing
2 participants
@alice-i-cecile @JJJimbo1