Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main branch fails to compile on Rust beta due to indentation in docs #14221

Closed
github-actions bot opened this issue Jul 8, 2024 · 1 comment · Fixed by #14225
Closed

Main branch fails to compile on Rust beta due to indentation in docs #14221

github-actions bot opened this issue Jul 8, 2024 · 1 comment · Fixed by #14225
Labels
C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Weekly CI run has failed.

The offending run.
@github-actions github-actions bot added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 8, 2024
@janhohenheim janhohenheim added P-High This is particularly urgent, and deserves immediate attention P-Compile-Failure A failure to compile Bevy apps and removed S-Needs-Triage This issue needs to be labelled P-High This is particularly urgent, and deserves immediate attention labels Jul 8, 2024
@janhohenheim
Copy link
Member

New doc comments are not adhering to the new indentation lints, and so the same issue as a while ago is back. Simple fix.

@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jul 8, 2024
@rparrett rparrett mentioned this issue Jul 8, 2024
Merged
@alice-i-cecile alice-i-cecile changed the title Main branch fails to compile on Rust beta. Main branch fails to compile on Rust beta due to indentation in docs Jul 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 9, 2024
@rparrett
Fix doc list indentation (#14225)
3594c4f 
# Objective

Fixes #14221

## Solution

Add indentation as suggested.

## Testing

Confirmed that
- This makes Clippy happy with rust beta
- Built docs visually look the same before/after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix doc list indentation rparrett/bevy
1 participant
@janhohenheim