Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaname PluginGroupBuilder::add to push #15305

Closed
alice-i-cecile opened this issue Sep 19, 2024 · 1 comment
Closed

Reaname PluginGroupBuilder::add to push #15305

alice-i-cecile opened this issue Sep 19, 2024 · 1 comment
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Sep 19, 2024 •
edited
Loading

We should rename PluginGroupBuilder::add to push

Spotted in #15301.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Sep 19, 2024
@richchurcher richchurcher mentioned this issue Sep 19, 2024
Closed
@mockersf
Copy link
Member

I would prefer to keep the add terminology which is a lot clearer, and maybe rename the add method to add_plugin if we want to avoid the lint

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@alice-i-cecile alice-i-cecile mentioned this issue Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename PluginGroupBuilder: add -> push, add_group -> push_group richchurcher/bevy
2 participants
@alice-i-cecile @mockersf