Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PluginGroupBuilder: add -> push, add_group -> push_group #15316

Closed
wants to merge 1 commit into from
Closed

Rename PluginGroupBuilder: add -> push, add_group -> push_group #15316

wants to merge 1 commit into from

Conversation

richchurcher
Copy link
Contributor

Objective

  • Renames PluginGroupBuilder::add to push, since that's what it does
  • For consistency, renames add_group to push_group

Closes #15305.

Migration Guide

  • Change all uses of PluginGroupBuilder::add to PluginGroupBuilder::push.
  • Change all uses of PluginGroupBuidler::add_group to PluginGroupBuilder::push_group.

mockersf
mockersf reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming add to push is a lot less clear, I don't think it's a good idea

@mockersf mockersf added the X-Controversial There is active debate or serious implications around merging this PR label Sep 19, 2024
@alice-i-cecile
Copy link
Member

Deferring to Francois here. I don't care enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf left review comments

Assignees
No one assigned
Labels
X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reaname PluginGroupBuilder::add to push
3 participants
@richchurcher @alice-i-cecile @mockersf