Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that benchmarks continue to compile #2674

Closed
alice-i-cecile opened this issue Aug 18, 2021 · 0 comments
Closed

Ensure that benchmarks continue to compile #2674

alice-i-cecile opened this issue Aug 18, 2021 · 0 comments
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change

Comments

@alice-i-cecile
Copy link
Member

As noticed in #2673, our benchmark code can silently go stale and fail to compile. Obviously, this is bad and we should fix it.

Running the benchmarks for each PR is too expensive and noisy (in terms of time, compute and developer attention), but verifying that they compile is much cheaper.

@cart's opinion is that this should be a separate step in the CI, rather than handled by integrating the CI into the main Bevy cargo workspace.
@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change labels Aug 18, 2021
@mockersf mockersf mentioned this issue Aug 18, 2021
Closed
bors bot pushed a commit that referenced this issue Aug 26, 2021
@mockersf
check that benches build (#2675)
9dd29a5 
# Objective

- Fixes #2674 
- Check that benches build

## Solution

- Adds a job that runs `cargo check --benches`
@bors bors bot closed this as completed in f6b42b8 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - check that benches build mockersf/bevy
1 participant
@alice-i-cecile