Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collide doesn't get all possible intersections #4478

Closed
dbofmmbt opened this issue Apr 15, 2022 · 3 comments
Closed

collide doesn't get all possible intersections #4478

dbofmmbt opened this issue Apr 15, 2022 · 3 comments
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@dbofmmbt
Copy link

Bevy version

0.6 (I checked and main has the problem too).

What you did

image

What you expected to happen

collide should return Some(...).

What actually happened

It returned None i.e. it didn't get a intersection when there's no corner inside the intersection area.
@dbofmmbt dbofmmbt added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 15, 2022
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Math Fundamental domain-agnostic mathematical operations and removed S-Needs-Triage This issue needs to be labelled labels Apr 15, 2022
@alice-i-cecile
Copy link
Member

Checks out. Should be an easy tweak to use a more sensible AABB collision algorithm :)

@dbofmmbt
Copy link
Author

I decided to work on it. 🚀

@dbofmmbt dbofmmbt mentioned this issue Apr 15, 2022
Closed
dbofmmbt pushed a commit to dbofmmbt/bevy that referenced this issue Apr 15, 2022
improve collide handling
c48066b 
bug fix + refactor. Closes bevyengine#4478
@dbofmmbt
Copy link
Author

I just noticed that #2489 fixed it. I must have looked at tag 0.6 instead of the main branch when checking if the problem was present in the latest version of the code base. Anyway, my PR became a refactor... still worth it, though =)

tygyh pushed a commit to tygyh/bevy that referenced this issue Dec 27, 2023
@tygyh
improve collide handling
f8c487c 
bug fix + refactor. Closes bevyengine#4478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @dbofmmbt