-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more system information as a diagnostics #5464
Labels
A-Diagnostics
Logging, crash handling, error reporting and performance analysis
C-Feature
A new feature, making something new possible
D-Trivial
Nice and easy! A great choice to get started with Bevy
Comments
IceSentry
added
C-Feature
A new feature, making something new possible
D-Trivial
Nice and easy! A great choice to get started with Bevy
A-Diagnostics
Logging, crash handling, error reporting and performance analysis
labels
Jul 26, 2022
Hello! |
Try to hear @IceSentry and @l1npengtul first, since they already opened the PRs you see above. |
I see! #5911 seams to already solve this issue. I will move on to something else then. Thank you. |
bors bot
pushed a commit
that referenced
this issue
Jan 2, 2023
# Objective Solve #5464 ## Solution Adds a `SystemInformationDiagnosticsPlugin` to add diagnostics. Adds `Cargo.toml` flags to fix building on different platforms. --- ## Changelog Adds `sysinfo` crate to `bevy-diagnostics`. Changes in import order are due to clippy. Co-authored-by: l1npengtul <35755164+l1npengtul@users.noreply.github.com> Co-authored-by: IceSentry <c.giguere42@gmail.com>
I guess this issue can be closed now as #5911 has been merged. |
alradish
pushed a commit
to alradish/bevy
that referenced
this issue
Jan 22, 2023
…e#5911) # Objective Solve bevyengine#5464 ## Solution Adds a `SystemInformationDiagnosticsPlugin` to add diagnostics. Adds `Cargo.toml` flags to fix building on different platforms. --- ## Changelog Adds `sysinfo` crate to `bevy-diagnostics`. Changes in import order are due to clippy. Co-authored-by: l1npengtul <35755164+l1npengtul@users.noreply.github.com> Co-authored-by: IceSentry <c.giguere42@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this issue
Feb 1, 2023
…e#5911) # Objective Solve bevyengine#5464 ## Solution Adds a `SystemInformationDiagnosticsPlugin` to add diagnostics. Adds `Cargo.toml` flags to fix building on different platforms. --- ## Changelog Adds `sysinfo` crate to `bevy-diagnostics`. Changes in import order are due to clippy. Co-authored-by: l1npengtul <35755164+l1npengtul@users.noreply.github.com> Co-authored-by: IceSentry <c.giguere42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Diagnostics
Logging, crash handling, error reporting and performance analysis
C-Feature
A new feature, making something new possible
D-Trivial
Nice and easy! A great choice to get started with Bevy
What problem does this solve or what need does it fill?
When debugging performance it can be helpful to know things like cpu usage and memory usage
What solution would you like?
Add a
SystemInformationDiagnosticsPlugin
to bevy_diagnostics that queries the cpu usage and memory usage and adds them as a diagnostic.This plugin could also add the SystemInfo from #5454 as a
Res
to make this data accessible to other parts of the engine.What alternative(s) have you considered?
None
Additional context
#5454 added a log on startup to give more information about the system, The same crate used in that PR should be used to query this data each frame.
The text was updated successfully, but these errors were encountered: