Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bevy_window and bevy_input events serializable #6021

Closed
alice-i-cecile opened this issue Sep 19, 2022 · 4 comments
Closed

Make bevy_window and bevy_input events serializable #6021

alice-i-cecile opened this issue Sep 19, 2022 · 4 comments
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in C-Testing A change that impacts how we test Bevy or how users test their apps C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Sep 19, 2022 •
edited
Loading

What problem does this solve or what need does it fill?

All of the events in this file should be serializable, in order to enable effective playback of window events for testing.

Similarly, many events in bevy_input are not serializable.

What solution would you like?

Add derives for Serialize and Deserialize, controlled by an off-by-default feature flag.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Windowing Platform-agnostic interface layer to run your app in C-Usability A simple quality-of-life change that makes Bevy easier to use C-Testing A change that impacts how we test Bevy or how users test their apps labels Sep 19, 2022
@alice-i-cecile alice-i-cecile changed the title Make bevy_window events serializable Make bevy_window and bevy_input events serializable Sep 19, 2022
@alice-i-cecile alice-i-cecile added the A-Input Player input via keyboard, mouse, gamepad, and more label Sep 19, 2022
@alice-i-cecile alice-i-cecile mentioned this issue Sep 19, 2022
Closed
@emersonmx emersonmx mentioned this issue Oct 6, 2022
Closed
@emersonmx
Copy link
Contributor

Hello.
I started to see this issue, but I can't tell what should be serialized or not in bevy_input.
I found this too, but I don't know if I need to put it in all struct of touch.rs or if only in those that are commented out as an event. Example: A touch input event.

@alice-i-cecile
Copy link
Member Author

Hmm, good question. WRT touch data, it's hard to say, as I haven't experimented with Bevy on touch devices yet. For my purposes, I think TouchInput is the only critical one.

@bors bors bot closed this as completed in 087f1c6 Oct 6, 2022
@alice-i-cecile alice-i-cecile reopened this Oct 6, 2022
@alice-i-cecile
Copy link
Member Author

Reopening so we can tackle touch input events too.

@emersonmx
Copy link
Contributor

Hello again 👋🏻
The only places I could find to put "serialize" were TouchInput and ForceTouch.

@emersonmx emersonmx mentioned this issue Oct 6, 2022
Closed
@bors bors bot closed this as completed in 7673db7 Oct 11, 2022
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 19, 2022
@emersonmx @james7132
Make bevy_window and bevy_input events serializable (bevyengine#6180)
c56af14 
Closes bevyengine#6021
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 19, 2022
@emersonmx @james7132
Make TouchInput and ForceTouch serializable (bevyengine#6191)
731795f 
Closes bevyengine#6021
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@emersonmx @james7132
Make bevy_window and bevy_input events serializable (bevyengine#6180)
7c2ad80 
Closes bevyengine#6021
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@emersonmx @james7132
Make TouchInput and ForceTouch serializable (bevyengine#6191)
cc6c891 
Closes bevyengine#6021
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this issue Dec 17, 2022
@emersonmx @Pietrek14
Make TouchInput and ForceTouch serializable (bevyengine#6191)
bc998e6 
Closes bevyengine#6021
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@emersonmx @ItsDoot
Make bevy_window and bevy_input events serializable (bevyengine#6180)
ee33398 
Closes bevyengine#6021
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@emersonmx @ItsDoot
Make TouchInput and ForceTouch serializable (bevyengine#6191)
0cbebaf 
Closes bevyengine#6021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in C-Testing A change that impacts how we test Bevy or how users test their apps C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
2 participants
@emersonmx @alice-i-cecile