Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamically_load_plugin should take an OsStr-like argument, not a &str #6711

Closed
alice-i-cecile opened this issue Nov 21, 2022 · 0 comments
Closed

dynamically_load_plugin should take an OsStr-like argument, not a &str #6711

alice-i-cecile opened this issue Nov 21, 2022 · 0 comments
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

Spotted when reviewing #6705.

The argument here should follow the called method in Library::new, rather than arbitrarily restricting it to a less clear, less type safe raw string.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-App Bevy apps and plugins labels Nov 21, 2022
@polygon polygon mentioned this issue Nov 22, 2022
Closed
@bors bors bot closed this as completed in 9f0c41f Dec 5, 2022
ickshonpe pushed a commit to ickshonpe/bevy that referenced this issue Dec 6, 2022
@polygon @ickshonpe
Adapt path type of dynamically_load_plugin (bevyengine#6734)
14b4d3f 
# Objective

- Fixes bevyengine#6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@polygon @alradish
Adapt path type of dynamically_load_plugin (bevyengine#6734)
b4f5735 
# Objective

- Fixes bevyengine#6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@polygon @ItsDoot
Adapt path type of dynamically_load_plugin (bevyengine#6734)
7919ca3 
# Objective

- Fixes bevyengine#6711

## Solution

- Change the `path` function parameter of `dynamically_load_plugin` and `DynamicPluginExt::load_plugin` to a generic with `AsRef<OsStr>` bound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Adapt path type of dynamically_load_plugin polygon/bevy
1 participant
@alice-i-cecile