bevy_reflect: Support Cow<'static, [T]> #7429
Labels
A-Reflection
Runtime information about types
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
D-Trivial
Nice and easy! A great choice to get started with Bevy
Comments
ItsDoot
added
C-Feature
alice-i-cecile
added
C-Usability
|
Wonder if we should generically support |
alice-i-cecile
pushed a commit
that referenced
this issue
May 8, 2023
# Objective - Add Reflect and FromReflect for AssetPath - Fixes #8458 ## Solution - Straightforward derive of `Reflect` and `FromReflect` for `AssetPath` - Implement `Reflect` and `FromReflect` for `Cow<'static, Path>` as to satisfy the 'static lifetime requierments of bevy_reflect. Implementation is a direct copy of that for `Cow<'static, str>` so maybe it begs the question that was already asked in #7429 - maybe it would be benefitial to write a general implementation for `Reflect` for `Cow<'static, T>`.
james7132
pushed a commit
to james7132/bevy
that referenced
this issue
Jun 19, 2023
# Objective - Implementing reflection for Cow<'static, [T]> - Hopefully fixes bevyengine#7429 ## Solution - Implementing Reflect, Typed, GetTypeRegistration, and FromReflect for Cow<'static, [T]> --- ## Notes I have not used bevy_reflection much yet, so I may not fully understand all the use cases. This is also my first attempt at contributing, so I would appreciate any feedback or recommendations for changes. I tried to add cases for using Cow<'static, str> and Cow<'static, [u8]> to some of the bevy_reflect tests, but I can't guarantee those tests are comprehensive enough. --------- Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
At present, only
Cow<'static, str>implementsReflect. However,Cowhas another use:Cow<'static, [T]>for owned or borrowed lists.What solution would you like?
Implement
Reflectand all other associated/required traits forCow<'static, [T]>.What alternative(s) have you considered?
Just use a
Vec<T>. However,Vecs don't work for const lists like arrays, and potentially use up more memory in the same way aStringandCow<'static, str>are compared.The text was updated successfully, but these errors were encountered: