Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normals for StandardMaterial when using prepass don't match without prepass. #8746

Closed
DGriffin91 opened this issue Jun 3, 2023 · 3 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Milestone

Comments

@DGriffin91
Copy link
Contributor

Bevy version

d115828

Normals for the StandardMaterial when the prepass is used don't have the same values as when the prepass is not used.

Without prepass:
no prepass

With prepass:
prepass

Without prepass:
just normals no prepass

With prepass:
just normals prepass

@DGriffin91 DGriffin91 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jun 3, 2023
@DGriffin91
Copy link
Contributor Author

Parallax mapping is also broken with the prepass. I'm guessing the issue is related.

Without Prepass:
parallax_forward

With Prepass:
image

@JMS55 JMS55 added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jun 3, 2023
@JMS55
Copy link
Contributor

JMS55 commented Jun 3, 2023

The parallax mapping issue at least seems to be caused by the normal prepass not accounting for parallax mapping. Same for the depth prepass #8486, as well as motion vectors. Skinning has the same issue, but only for motion vectors.

While the prepass output isn't matching the main pass, the reason it affects the main pass is due to #8231.

@JMS55 JMS55 added this to the 0.11 milestone Jun 3, 2023
@alice-i-cecile
Copy link
Member

Fixed by #8890.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

3 participants