WIP: Update depth buffer with parallax mapping result #8486
+212
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easier to read a multicolor gradient than grayscale one.
nicopap
added
C-Enhancement
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The current parallax mapping implementation doesn't play well with depth-based feature, since it only updates the fragment color in the main pass.
Effects that depend on depth will not work properly. This includes existing and future rendering features, such as:
Solution
We update
pbr_prepassto account for depth evaluated by parallax mappingTODO
Everything is broken, the code is full of debug stuff 😅