Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change visibility of bevy::core::update_frame_count to pub #10111

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Change visibility of bevy::core::update_frame_count to pub #10111

merged 2 commits into from
Oct 16, 2023

Conversation

mamekoro
Copy link
Contributor

Objective

Closes #10107

The visibility of bevy::core::update_frame_count should be pub so it can be used in third-party code like this:

impl Plugin for MyPlugin {
    fn build(&self, app: &mut App) {
        app.add_systems(Last, use_frame_count.before(bevy::core::update_frame_count));
    }
}

Solution

Make bevy::core::update_frame_count public.

Changelog

Added

  • Documentation for bevy::core::update_frame_count

Changed

  • Visibility of bevy::core::update_frame_count is now pub

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@hymm hymm added A-Core Common functionality for all bevy apps C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 13, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 16, 2023
Merged via the queue into bevyengine:main with commit 1258ceb Oct 16, 2023
25 checks passed
@mamekoro mamekoro deleted the pub-update-frame-count branch November 5, 2023 17:42
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mamekoro @ameknite
Change visibility of bevy::core::update_frame_count to pub (bevye…
ef2fca2 
…ngine#10111)

# Objective
Closes bevyengine#10107

The visibility of `bevy::core::update_frame_count` should be `pub` so it
can be used in third-party code like this:

```rust
impl Plugin for MyPlugin {
    fn build(&self, app: &mut App) {
        app.add_systems(Last, use_frame_count.before(bevy::core::update_frame_count));
    }
}
```

## Solution
Make `bevy::core::update_frame_count` public.

---

## Changelog

### Added
- Documentation for `bevy::core::update_frame_count`

### Changed
- Visibility of `bevy::core::update_frame_count` is now `pub`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mamekoro
Change visibility of bevy::core::update_frame_count to pub (bevye…
a22220e 
…ngine#10111)

# Objective
Closes bevyengine#10107

The visibility of `bevy::core::update_frame_count` should be `pub` so it
can be used in third-party code like this:

```rust
impl Plugin for MyPlugin {
    fn build(&self, app: &mut App) {
        app.add_systems(Last, use_frame_count.before(bevy::core::update_frame_count));
    }
}
```

## Solution
Make `bevy::core::update_frame_count` public.

---

## Changelog

### Added
- Documentation for `bevy::core::update_frame_count`

### Changed
- Visibility of `bevy::core::update_frame_count` is now `pub`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsolage afonsolage afonsolage approved these changes

@hymm hymm hymm approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make bevy::core::update_frame_count public
5 participants
@mamekoro @afonsolage @hymm @IceSentry @alice-i-cecile