Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic when failing to create assets folder (#10613) #10614

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

tripokey
Copy link
Contributor

Objective

  • Allow bevy applications that does not have any assets folder to start from a read-only directory. (typically installed to a systems folder)

Fixes #10613

Solution

  • warn instead of panic when assets folder creation fails.

# Objective

- Allow bevy applications that does not have any
  assets folder to start from a read-only directory.
  (typically installed to a systems folder)

## Solution

- warn instead of panic when assets folder creation
  fails.
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds labels Nov 17, 2023
@alice-i-cecile alice-i-cecile added this to the 0.12.1 milestone Nov 17, 2023
@cart cart added this pull request to the merge queue Nov 17, 2023
Merged via the queue into bevyengine:main with commit 9a909f5 Nov 17, 2023
24 checks passed
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 17, 2023
cart pushed a commit that referenced this pull request Nov 30, 2023
# Objective

- Allow bevy applications that does not have any assets folder to start
from a read-only directory. (typically installed to a systems folder)

Fixes #10613

## Solution

- warn instead of panic when assets folder creation fails.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
…evyengine#10614)

# Objective

- Allow bevy applications that does not have any assets folder to start
from a read-only directory. (typically installed to a systems folder)

Fixes bevyengine#10613

## Solution

- warn instead of panic when assets folder creation fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bevy panics if started from a read-only directory without an assets folder
3 participants