Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ScheduleGraph::process_configs function #10617

Closed
wants to merge 1 commit into from
Closed

Split ScheduleGraph::process_configs function #10617

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

Just split it into several functions, because it is too large and hard to read. No functional changes.

@ItsDoot ItsDoot added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Nov 17, 2023
@stepancheg
Split ScheduleGraph::process_configs function
dde8fb5 
Just split it into several functions, because it is too large and
hard to read. No functional changes.
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! labels Feb 27, 2024
@alice-i-cecile
Copy link
Member

Non-trivial merge conflicts. @stepancheg if you resolve them I'll merge this in, otherwise I've put this up for adoption.

@yyogo yyogo mentioned this pull request Mar 12, 2024
Merged
@james7132
Copy link
Member

Closing in favor of #12435, which adopted this PR.

@james7132 james7132 closed this Mar 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 17, 2024
@yyogo @stepancheg
Split ScheduleGraph::process_configs function (adopted) (#12435)
e9dc270 
Adoption of #10617, resolved conflicts with main

---------

Co-authored-by: Stepan Koltsov <stepan.koltsov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancheg @alice-i-cecile @james7132 @ItsDoot