Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update event-listener requirement from 2.5 to 4.0 #10654

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2023

Updates the requirements on event-listener to permit the latest version.

Release notes

Sourced from event-listener's releases.

v4.0.0

  • Breaking: Fix a footgun in the EventListener type. EventListener::new() now no longer takes an &Event as an argument, and EventListener::listen() takes the &Event as an argument. Hopefully this should prevent .awaiting on a listener without making sure it's listening first. (#94)
Changelog

Sourced from event-listener's changelog.

Version 4.0.0

  • Breaking: Fix a footgun in the EventListener type. EventListener::new() now no longer takes an &Event as an argument, and EventListener::listen() takes the &Event as an argument. Hopefully this should prevent .awaiting on a listener without making sure it's listening first. (#94)

Version 3.1.0

  • Implement UnwindSafe and RefUnwindSafe for EventListener. This was unintentionally removed in version 3 (#96).

Version 3.0.1

  • Emphasize that listen() must be called on EventListener in documentation. (#90)
  • Write useful output in fmt::Debug implementations. (#86)

Version 3.0.0

  • Use the parking crate instead of threading APIs (#27)
  • Bump MSRV to 1.59 (#71)
  • Breaking: Make this crate no_std-compatible on default-features = false. (#34)
  • Create a new event-listener-strategy crate for abstracting over blocking/non-blocking operations. (#49)
  • Breaking: Change the EventListener API to be !Unpin. (#51)
  • Enable a feature for the portable-atomic crate. (#53)
  • Breaking: Add a Notification trait which is used to enable tagged events. (#52)
  • Add an is_notified() method to Event. (#48)
  • Breaking: Make it so notify() returns the number of listeners notified. (#57)

Version 2.5.3

  • Fix fence on x86 and miri.

Version 2.5.2

  • Fix stacked borrows violation when -Zmiri-tag-raw-pointers is enabled. (#24)

Version 2.5.1

  • Replace spinlock with a mutex.

Version 2.5.0

  • Add EventListener::discard().

Version 2.4.0

  • Event::new() is now a const fn.

Version 2.3.3

... (truncated)

Commits
  • 531c106 v4.0.0
  • 21b34bf breaking: Fix the EventListener::new() footgun
  • e6ec597 v3.1.0
  • 3f0d516 feat: Implement UnwindSafe for EventListener
  • c42dc40 Update futures-lite requirement from 1.12.0 to 2.0.0
  • ca65475 v3.0.1
  • 74e8231 m: Update fmt::Debug to produce new info
  • e8a1727 Merge pull request #90 from smol-rs/notgull/new-docs
  • 5c11241 Fix doctest and nitpick
  • ac3978e docs: Document that EventListeners must be listen'd on
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [event-listener](https://github.com/smol-rs/event-listener) to permit the latest version.
- [Release notes](https://github.com/smol-rs/event-listener/releases)
- [Changelog](https://github.com/smol-rs/event-listener/blob/master/CHANGELOG.md)
- [Commits](smol-rs/event-listener@v2.5.0...v4.0.0)

---
updated-dependencies:
- dependency-name: event-listener
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Nov 20, 2023
@hymm
Copy link
Contributor

hymm commented Nov 22, 2023

Feels like we should upgrade to 3 instead of 4 rn. Most of our dependencies that use this are still on v3.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/event-listener-4.0 branch January 9, 2024 16:00
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2024
# Objective

This dependency is seemingly no longer used directly after #7267.

Unfortunately, this doesn't fix us having versions of `event-listener`
in our tree.

Closes #10654

## Solution

Remove it, see if anything breaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants