Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docs with Github Pages artifacts #10888

Closed
wants to merge 1 commit into from
Closed

Publish docs with Github Pages artifacts #10888

wants to merge 1 commit into from

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Dec 6, 2023

Objective

Closes #10821

Solution

Notes

  • I made this workflow possible to run through dispatch (workflow_dispatch), in case something goes wrong.
  • I restricted the permissions to just the things Github Pages needs.
  • I made it so that only one deployments can happen at a time, the other deployment requests will be queued up and the latest one will be run.
  • My local fork got borked by a glitch, so it builds perfectly fine but fails during the deployment job. It shouldn't happen to you, but I want to test before this gets merged.

@ItsDoot ItsDoot added C-Feature A new feature, making something new possible A-Build-System Related to build systems or continuous integration labels Dec 6, 2023
@BD103 BD103 closed this by deleting the head repository Dec 6, 2023
@BD103
Copy link
Member Author

BD103 commented Dec 6, 2023

I needed to delete my fork in order to get rid of the bug. I'll re-open a new PR once I can confirm it works.

github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2024
Supersedes #10888.

# Objective

Closes #10821

## Solution

- Replaced
[JamesIves/github-pages-deploy-action](https://github.com/JamesIves/github-pages-deploy-action)
with
[actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact)
and [actions/deploy-pages](https://github.com/actions/deploy-pages).

## Notes

- I made this workflow possible to run through dispatch
(`workflow_dispatch`), in case something goes wrong.
- I restricted the permissions to just the things Github Pages needs.
- I made it so that only one deployments can happen at a time, the other
deployment requests will be queued up and the latest one will be run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish docs with pages artifact
2 participants