Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Labels #1142

Closed
wants to merge 2 commits into from
Closed

Fix Labels #1142

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

found two issues with Labels while trying to use them in a scene:

  • they are not registered which caused panic thread 'main' panicked at 'scene contains the unregistered type bevy_core::label::Labels
  • a new label was not added to the label_entities hash map so it remained empty

@mockersf
Copy link
Member Author

I didn't touch the TODO: use Changed as the system is running in stage PRE_UPDATE
Should the stage be changed?

@payload
Copy link
Contributor

payload commented Dec 26, 2020

Note that removing the labels afte entity despawn looks like also broken. Adding tests to this file would be good.

@payload
Copy link
Contributor

payload commented Dec 26, 2020

I propose this PR as an alternative which fixes some corner cases and tests them. Feel free to take the tests in case you want to take a different approach: #1152

@Moxinilian Moxinilian added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events labels Dec 26, 2020
@cart
Copy link
Member

cart commented Dec 28, 2020

Closing in favor of #1152

@cart cart closed this Dec 28, 2020
@mockersf mockersf deleted the fix-labels branch April 27, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants