-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Arc3D for Gizmos #11540
Implement Arc3D for Gizmos #11540
Commits on Jan 26, 2024
-
feat(arc3d): add
arc3d
methods forGizmos
The API of this implementation mimics unity's API for the same feature, c.f. https://docs.unity3d.com/ScriptReference/Handles.DrawWireArc.html This was done since it seems to be the most flexible design so far allowing for arcs with arc angles in the range of [-360.0, 360.0] degrees. Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6641e67 - Browse repository at this point
Copy the full SHA 6641e67View commit details -
refactor(arc3d): redesign arc3d API
I noticed some flaws with the original implementation of the API while creating some examples: - The orientation via `from` and `rotation_axis` fields felt really wonky - The rotation seemed not to rotate around the center set by the user This is why I reimplemented the API. It now draws some kind of default arc in 3D which has properties which are documented in the doc strings. You can modify this default arc via builder methods which seems to be the most flexible approach in my eyes. Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5605b21 - Browse repository at this point
Copy the full SHA 5605b21View commit details -
docs(example): add arc3d example to 3d_gizmos
Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 219a44d - Browse repository at this point
Copy the full SHA 219a44dView commit details -
chore(cleanup): reuse new logic + cleanups
- reuse new factored out function to calculate the default amount of segments for arc2d - add the gizmos active check to arc3d - also implement optional segments logic for arc3d - cleanup debug gizmo center drawing
Configuration menu - View commit details
-
Copy full SHA for c153046 - Browse repository at this point
Copy the full SHA c153046View commit details -
feat(arc3d): add shortest/longest arc implementations
Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d4e19e3 - Browse repository at this point
Copy the full SHA d4e19e3View commit details -
docs(arc3d): rewording undefined behavior part to less drastic words
Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 221a282 - Browse repository at this point
Copy the full SHA 221a282View commit details -
fix(review): circumvent ambiguity if
from == to
Thanks for spotting this Alice! Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd1b114 - Browse repository at this point
Copy the full SHA bd1b114View commit details
Commits on Jan 27, 2024
-
fix(review): make API consistent
and also adjust: - docs - tests - examples Authored-by: RobWalt <robwalter96@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e064f0 - Browse repository at this point
Copy the full SHA 2e064f0View commit details