Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New circular primitives: Arc2d, CircularSector, CircularSegment #11748

Closed
wants to merge 23 commits into from

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    f637de3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b88d45 View commit details
    Browse the repository at this point in the history
  3. Fix doc errors.

    spectria-limina committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c36edb5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1947ac0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    33e2dd2 View commit details
    Browse the repository at this point in the history
  6. Fix Circular{Sector,Segment} UV-mapping and add an example.

    This required adding a parameterizable angle for the UV mapping.
    
    It's in an enum to reduce the amount of churn if/when we add additional modes.
    spectria-limina committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    971f9b0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    609d238 View commit details
    Browse the repository at this point in the history
  8. Some more small cleanups.

    Change the default angle to a third of a circle, because a quarter leads
    to too thin of a segment.
    
    Also formatting changes in 2d_shapes.rs.
    spectria-limina committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    faabb28 View commit details
    Browse the repository at this point in the history
  9. Update examples page.

    spectria-limina committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    41806b7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9240e7e View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    ac33ec6 View commit details
    Browse the repository at this point in the history
  2. Add tests for arc bounding shapes.

    There were bugs.
    spectria-limina committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    a4fc07f View commit details
    Browse the repository at this point in the history
  3. Add tests to bounding shapes for CircularSector.

    Also draw bounding boxes on the mesh example to visually confirm
    correctness.
    spectria-limina committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    fa6c681 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Silence clippy and CI.

    Every suggestion for the boolean condition is less readable.
    spectria-limina committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    efb0515 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    3d47652 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Apply suggestions from code review

    Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
    Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
    3 people authored Mar 9, 2024
    Configuration menu
    Copy the full SHA
    552aea5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31b2be3 View commit details
    Browse the repository at this point in the history
  3. Review changes

    spectria-limina committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    9353ad0 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. More review comments

    spectria-limina committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    1c31b1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4cd5957 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    2e0740c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb29d40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1eaf343 View commit details
    Browse the repository at this point in the history