Don't try to create a uniform buffer for light probes if there are no views. #11751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
views. Fixes the panic on examples that have no views, such as `touch_input_events`.
|
I can confirm this resolves the crash I was getting with only a 2d camera active. |
ghost
approved these changes
Feb 7, 2024
ghost
added
C-Bug
pcwalton
added
the
S-Ready-For-Final-Review
IceSentry
approved these changes
Feb 7, 2024
mockersf
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to create a uniform buffer for light probes if there are no views.
Fixes the panic on examples that have no views, such as
touch_input_events.