remove panics when mixing UI and non UI entities in hierarchy #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
commented
Dec 31, 2020
| if let Ok(parent_layout) = flex_surface.get_layout(parent.0) { | ||
| position.x -= to_logical(parent_layout.size.width / 2.0); | ||
| position.y -= to_logical(parent_layout.size.height / 2.0); | ||
| if parent_flags.changed() || transform_flags.changed() { |
There was a problem hiding this comment.
added this check so that the log doesn't happen every frame
Moxinilian
added
C-Feature
|
This looks good to me. I agree that a link (probably to a section in the Bevy Book faq) would be beneficial, but we might as well merge this now to get the benefits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two
unwrapthat can happen when having a mix of entities with and without ui components (mainlyNode&Style) in a hierarchy, and replace them by a warning and a failover.I think the log would greatly benefit from a link to a page (official FAQ? GitHub wiki?) describing the problem in more details than what a log can say