bevy_color: Add Tailwind palette #12080
Conversation
|
I'm pretty sure we should include the tailwind license in the file and maybe also mention it in the docs. It's just MIT so it's compatible, with us but not sure about the apache case. |
|
Here's how I did that in an old crate of mine https://github.com/IceSentry/bevy_ui_styled/blob/master/src/colors.rs It was copied from here https://github.com/tailwindlabs/tailwindcss/blob/master/LICENSE |
There was a problem hiding this comment.
I'll approve, but I think we'll want @cart involved here because of the license situation. It's a bit of an edge case if someone wants to use bevy with the apache license they can't use that module I guess. I honestly don't know enough about licensing.
alice-i-cecile
added
C-Enhancement
alice-i-cecile
added
the
X-Controversial
|
I'm pretty firmly of the opinion that this is fine from a licensing perspective. MIT allows users to relicense the code (as long as they provide attribution and a copy of the license). It doesn't include a patent grant, but this is a color palette: I don't think that's a relevant concern. |
|
don't want to hamper any progress here, but couldn't this very easily be a standalone community crate? this is of course true for the other palettes, but at least the css and stand-alone modules are more "ubiquitous". the actual implementation is solid, though. |
It definitely could, but I'd like to have access to at least one "good" color palette: it's really painful trying to build nice examples and dev tools with only hand-authored magic values and the terrible CSS colors. |
Definitely. There are a few existing examples I know of: Which I am choosing to interpret as a sign that there is demand for this. IMO, the CSS palette we do provide may be ubiquitous, but it is also next to useless and is actively harming the look and feel of our examples and our users' projects. I suppose that's being a bit dramatic. I would still be very open to providing a single better "bevy palette" instead, but the way the palettes were modularized in the new |
|
yep. you've convinced me. |
|
I want to point out that it's pretty easy to algorithmically generate a good-looking palette, similar to Tailwind, Material Design, or whatever framework du jour you prefer, especially if you use Oklch to do the calculations, which gives you consistent lightness across different hues. |
# Objective Fixes #12226 Prior to the `bevy_color` port, `DARK GRAY` used to mean "dark grey." But it is now lighter than `GRAY`, matching the css4 spec. ## Solution Change usages of `css::DARK_GRAY` to `Color::srgb(0.25, 0.25, 0.25)` to restore the examples to their former colors. With one exception: `display_and_visibility`. I think the new color is an improvement. ## Note A lot of these examples could use nicer colors. I'm not trying to revamp everything here. The css4 palette is truly a horror. See #12176 and #12080 for some discussion about alternatives.
…ne#12333) # Objective Fixes bevyengine#12226 Prior to the `bevy_color` port, `DARK GRAY` used to mean "dark grey." But it is now lighter than `GRAY`, matching the css4 spec. ## Solution Change usages of `css::DARK_GRAY` to `Color::srgb(0.25, 0.25, 0.25)` to restore the examples to their former colors. With one exception: `display_and_visibility`. I think the new color is an improvement. ## Note A lot of these examples could use nicer colors. I'm not trying to revamp everything here. The css4 palette is truly a horror. See bevyengine#12176 and bevyengine#12080 for some discussion about alternatives.
|
BTW, I think the tailwind palette is fine. Yes, there are other palettes - MaterialUI, NextUI, Bootstrap, etc., but they are all about the same. We don't need more than one, and people know the name Tailwind, it has brand recognition. BTW, the NextUI palette is interesting, it's a bit funkier than most, you can see that none of the colors are "pure" tones - for example the reds have just a hint of purple in them, they are not a fire engine red that most other palettes would have. |
alice-i-cecile
removed
the
X-Controversial
Objective
Give Bevy a well-designed built-in color palette for users to use while prototyping or authoring Bevy examples.
Solution
Generate (playground, gist) consts from Tailwind (mit license) json.
Discussion
Are there other popular alternatives we should be looking at? Something new and fancy involving a really long acronym like CIELUVLCh? I'm not a tailwind user or color expert, but I really like the way it's broken up into distinct but plentiful hue and lightness groups.
It beats needing some shades of red, scrolling through the current palette, choosing a few of
CRIMSON,MAROON,RED,TOMATOat random and calling it a day.The best information I was able to dig up about the Tailwind palette is from this thread: https://twitter.com/steveschoger/status/1303795136703410180. Here are some key excerpts: