Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gizmo 3d grids #12430

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Gizmo 3d grids #12430

merged 8 commits into from
Mar 13, 2024

Conversation

lynn-lumen
Copy link
Contributor

Objective

Solution

  • Added 3d grids (grids spanning all three dimensions, not flat grids) to bevy_gizmos

Changelog

  • gizmos.grid(...) and gizmos.grid_2d(...) now return a GridBuilder2d.
  • Added gizmos.grid_3d(...) which returns a GridBuilder3d.
    • The difference between them is basically only that GridBuilder3d exposes some methods for configuring the z axis while the 2d version doesn't.
  • Allowed for drawing the outer edges along a specific axis by calling .outer_edges_x(), etc. on the builder.

Additional information

Please note that I have not added the 3d grid to any example as not to clutter them.
Here is an image of what the 3d grid looks like:
Screenshot 2024-03-12 at 02 19 55

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Gizmos Visual editor and debug gizmos labels Mar 12, 2024
@alice-i-cecile alice-i-cecile added the M-Needs-Release-Note Work that should be called out in the blog due to impact label Mar 12, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Mar 12, 2024
lynn-lumen and others added 3 commits March 12, 2024 02:26
@lynn-lumen
Fix CI
b691923
@lynn-lumen
Fix docs
5aefbb6
@lynn-lumen @alice-i-cecile
Change docs
f10037d 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@lynn-lumen
Copy link
Contributor Author

Apparently there is something wrong with bevy_reflect. Can someone help here?
😅

@alice-i-cecile
Copy link
Member

#12433 should fix the CI failure :)

pablo-lua
pablo-lua reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@pablo-lua pablo-lua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a few comments

crates/bevy_gizmos/src/grid.rs Outdated Show resolved Hide resolved
crates/bevy_gizmos/src/grid.rs Outdated Show resolved Hide resolved
crates/bevy_gizmos/src/grid.rs Outdated Show resolved Hide resolved
@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 13, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 13, 2024
Merged via the queue into bevyengine:main with commit ee0fa7d Mar 13, 2024
26 checks passed
@lynn-lumen lynn-lumen mentioned this pull request Apr 12, 2024
Open
57 tasks
This was referenced May 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-lua pablo-lua pablo-lua approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@nicopap nicopap Awaiting requested review from nicopap

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Feature A new feature, making something new possible M-Needs-Release-Note Work that should be called out in the blog due to impact S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@lynn-lumen @alice-i-cecile @pablo-lua