Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemId should manually implement Eq #12436

Merged
merged 1 commit into from
Mar 12, 2024
Merged

SystemId should manually implement Eq #12436

merged 1 commit into from
Mar 12, 2024

Conversation

eira-fransham
Copy link
Contributor

Objective

System<f32> currently does not implement Eq even though it should

Solution

Manually implement Eq like other traits are manually implemented

@pablo-lua pablo-lua added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 12, 2024
@james7132 james7132 added this to the 0.13.1 milestone Mar 12, 2024
@james7132 james7132 added this pull request to the merge queue Mar 12, 2024
Merged via the queue into bevyengine:main with commit baaf4c8 Mar 12, 2024
28 checks passed
mockersf pushed a commit that referenced this pull request Mar 13, 2024
@eira-fransham @mockersf
SystemId should manually implement Eq (#12436)
9f24bd8 
# Objective

`System<f32>` currently does not implement `Eq` even though it should

## Solution

Manually implement `Eq` like other traits are manually implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@eira-fransham @james7132 @pablo-lua